Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: l10n_ch vat 2024 backport V12 #1187

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from

Conversation

vrenaville
Copy link

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza
Copy link
Member

IMO, this should be done via extra module instead of here in OCB. If not, modules using this changed data won't be compatible with both flavors.

@pedrobaeza
Copy link
Member

Copy link

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza These are only localization data, IMO it's fine to have it merged since it is in newer versions of Odoo and modules shouldn't rely on such data.

@pedrobaeza
Copy link
Member

Yes, they rely as soon as it refers such data, even indirectly. My call is for not doing this, but an extra module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants